Apply linting

update Printer

README.md

@@ -79,16 +79,6 @@ Your contributions are very much welcome ! You can either request an account on
 
 Please also say if you had a printer to test your code, and which printer you've been using.
 
-### Code structure
-
-The app is written about the Flask framework. You can start by looking at the code in the `src/` folder, in the `main.py` file. There, you will see that a few classes are initialized. In general, they are two parts to the program :
-
-The Web pages and the API, which are the user-facing parts. This is with what the users will interact, and define how the program is going to be used. The web pages are renderer from the `include/` folder where Jinj2 templates are defined.
-
-The Worker and Printer Queue are the internal parts. When a new thing needs to be printed, usually sent from the Web or API interfaces, a new Task in the type of the document is created, and added to a print queue. Then, a Worker thread looks up the state of the queue every so often and picks jobs to execute on the printers connected to the system.
-
-The last part of the program is the Raspberry Pi class, that handles to Photomaton mode, which handles button presses, and LED indicator and a flash.
-
 ### Linting
 
 If you want to contribute code, please make sure to lint the project before commiting. This helps the code keep a general structure, and avoids some commons erros and mistakes.

configuration/config.toml

@@ -5,6 +5,8 @@ signature = "Anonymous"
 
 # Printer settings
 [printer]
+vendor_id = 0x04b8
+device_id = 0x0e28
 upload_folder = "src/static/uploads"
 
 # Raspberry Pi Configuration

pyproject.toml

@@ -7,7 +7,7 @@ authors = [
 ]
 license = "AGPLv3"
 readme = "README.md"
-requires-python = ">=3.13"
+requires-python = ">=3.14"
 dependencies = [
     "flask (>=3.1.3,<4.0.0)",
     "numpy (>=2.3.4)",

src/main.py

@@ -36,6 +36,7 @@ import werkzeug.exceptions
 from flask_socketio import SocketIO
 from flask_limiter import Limiter
 from flask_limiter.util import get_remote_address
+from printer import Printer  # The wrapper for the printer class
 from raspberry import Raspberry  # The Raspberry pi control Class
 from web import Web  # Wrapper for the web routes and API
 from print_queue import PrintQueue
@@ -72,7 +73,11 @@ except OSError as e:
 
 app.logger.debug("Config file loaded !")
 
+# Define the USB connections here.
+vendor_id = configuration_file["printer"]["vendor_id"]
+device_id = configuration_file["printer"]["device_id"]
 UPLOAD_FOLDER = str(configuration_file["printer"]["upload_folder"])
+
 try:
     os.mkdir(UPLOAD_FOLDER)
     app.logger.debug("Directory %s created successfully.", UPLOAD_FOLDER)
@@ -83,49 +88,54 @@ except PermissionError:
     sys.exit(77)
 
 # Output the config file
-if not os.getenv("FLASK_DEBUG") is None and os.getenv("FLASK_DEBUG") is True:
+if os.getenv("FLASK_DEBUG"):
     pprint.pprint(configuration_file)
 
 # We define the app module used by Flask
 app.secret_key = configuration_file["secrets"]["flask_secret_key"]
 app.config["UPLOAD_FOLDER"] = UPLOAD_FOLDER
 app.config["ALLOWED_EXTENSIONS"] = ALLOWED_EXTENSIONS
-app.config["MAX_CONTENT_LENGTH"] = 10 * 1000 * 1000  # Maximum 10Mb for a file upload
+app.config["MAX_CONTENT_LENGTH"] = 10 * 1000 * 1000  # Maximum 3Mb for a file upload
 app.config["TEMPLATES_AUTO_RELOAD"] = True
 
+# Printer connection
+# Uses the class defined in the printer.py file
+printer = Printer(app, 0x04B8, 0x0E28)
+# printers = Printer(app)
+# printers.discover_printers()
+# printers.init()
+printer.init_printer()
+
+# Find out if we are running on a Raspberry Pi
+rpi = Raspberry(
+    printer,
+    app,
+    socketio,
+    configuration_file["rpi"]["button_gpio_port_number"],
+    configuration_file["rpi"]["indicator_gpio_port_number"],
+    configuration_file["rpi"]["flash_gpio_port_number"],
+    configuration_file["rpi"]["flash"],
+)
+
+RASPBERRY_PI_CONNECTED = rpi.is_raspberry_pi()
+
 # Queue creation
 print_queue = PrintQueue(app)
 
-# Find out if we are running on a Raspberry Pi
+#  Web & API  routes
-rpi = Raspberry(
-    print_queue,
-    app,
-    configuration_file
-)
-RASPBERRY_PI_CONNECTED = rpi.is_raspberry_pi()
-
-
-#  Web & API management
 web = Web(app, print_queue)
 
 # Start worker thread
-# When created, the worker will try to find printers connected to the system
+worker = PrintWorker(app, print_queue, printer, socketio)
-try:
+worker.start()
-    worker = PrintWorker(app, print_queue)
-    worker.start()
-except Exception as e:
-    app.logger.error("Could not start the worker because %s ", str(e))
-    sys.exit(-1)
 
-# The rate limit
 limiter = Limiter(
     get_remote_address, app=app, default_limits=["1500 per day", "500 per hour"]
 )
 
-
-app.logger.info("🖶 Welcome to LittlePrynter !")
-
 # General routes
+
+
 @app.route("/")
 @limiter.limit("1/second", override_defaults=False)
 def index():
@@ -143,6 +153,8 @@ def webcam():
 
 
 # Form treatement
+
+
 @app.route("/web/print/sms", methods=["POST"])
 @limiter.limit("6/minute", override_defaults=False)
 def web_print_sms():
@@ -173,7 +185,7 @@ def web_print_sms():
         return redirect(url_for("index"))
 
     # end try
-    flash("The SMS has been added to the print queue !", "info")
+    flash("The SMS has been printed !", "info")
     return redirect(url_for("index"))
 
 
@@ -191,9 +203,6 @@ def web_print_img():
             "No signature found for this print, using default signature : %s", str(e)
         )
         sign = configuration_file["defaults"]["signature"]
-    except werkzeug.exceptions.RequestEntityTooLarge as e:
-        flash("Whoops, image is too big: " + str(e), "error")
-        return redirect(url_for("index"))
 
     # check if the post request has the file part
     if "img" not in request.files:
@@ -218,7 +227,7 @@ def web_print_img():
         flash("The image could not be printed because : " + str(e), "error")
         return redirect(url_for("index"))
 
-    flash("Picture added to the print queue !", "info")
+    flash("Picture printed !", "info")
     return redirect(url_for("index"))
 
 
@@ -287,7 +296,8 @@ def api_print_image():
         return "No image submitted", 400
 
     file = request.files["img"]
-    # If the user submits an empty file without a filename.
+    # If the user does not select a file, the browser submits an
+    # empty file without a filename.
     if file.filename == "":
         app.logger.error("Submitted file has no filename !")
         return "Submitted file has no filename !", 400
@@ -301,7 +311,6 @@ def api_print_image():
     return "OK", 200
 
 
-# TODO: This might not depend on the Raspberry Pi
 @app.route("/api/camera/picture", methods=["GET"])
 def camera_picture():
     """Returns a picture taken by the camera on a raspberry pi"""
@@ -320,12 +329,6 @@ def api_queue_status():
     return jsonify(web.get_queue_state())
 
 
-@app.route("/api/queue/completed", methods=["GET"])
-def api_queue_completed():
-    """API endpoint that returns the finished tasks"""
-    return jsonify(web.get_queue_completed())
-
-
 @app.route("/api/worker", methods=["GET"])
 def api_worker_state():
     """API endpoint to get the worker state"""
@@ -334,18 +337,12 @@ def api_worker_state():
 
 @app.route("/api/worker/start")
 def api_worker_start():
-    """
-    Enable to worker. This starts to process the print queue.
-    """
     worker.start_worker()
     return jsonify(worker.current_state())
 
 
 @app.route("/api/worker/stop")
 def api_worker_stop():
-    """
-    Stops the print queue. This stops the processing of the print queue.
-    """
     worker.stop_worker()
     return jsonify(worker.current_state())
 
@@ -407,4 +404,4 @@ def camera_status():
 
 
 if __name__ == "__main__":
-    app.run(use_reloader=False, host="0.0.0.0", ssl_context="adhoc")
+    app.run(debug=True, use_reloader=False, host="0.0.0.0", ssl_context="adhoc")

src/print_queue.py

@@ -76,16 +76,7 @@ class PrintQueue:
         """Return current queue state"""
         with self._lock:
             self.app.logger.debug("Return current queue state")
-            return [
+            return [{"task_id": t.task_id, "status": t.status} for t in self._queue]
-                {"task_id": t.task_id, "status": t.status, "type": str(t.task_type), "content": str(t.get_print_data())}
-                for t in self._queue
-            ]
-
-    def get_queue_completed(self):
-        """Return completed queue elements"""
-        with self._lock:
-            self.app.logger.debug("Return completed queue elements")
-            return self._completed_tasks
 
     def get_status(self, task_id):
         """Get full status info for a task"""

src/printer.py

@@ -1,129 +1,115 @@
-"""
-This class manages connexion to a Printer
-"""
 
+# import brother_ql
+from time import sleep
 import os.path
-import os
+
-from abc import ABC, abstractmethod
-from dataclasses import dataclass
-import time
-from enum import Enum
-import uuid
-import threading
-import usb.core
 from PIL import Image, ImageEnhance
 import numpy as np
 
-# Importing the modules needed for each supported printer Type
+# Importing the module to manage the connection to the printer.
 import escpos.printer
-from brother_ql.models import ModelsManager
-from brother_ql.backends import backend_factory
-from brother_ql.raster import BrotherQLRaster
-from brother_ql.conversion import convert
-from brother_ql.backends.helpers import send
 
 
-class PrinterType(Enum):
+class Printer(object):
     """
-    What are the capacities of a Printer ?
+    # The connection is based on the ESC/POS library
+
+    ## Connection to the USB printer
+
+    ## Making sure the printer is alive
+
+    ## Making sure it has paper
+
+    ## Define default print settings
+
+    ## Print starting message, log time of first print, cut.
+
+    ## Annonce readyness : return a positive pong message.
     """
 
-    EPSON = "epson"
+    # Is the printer ready to accept a new print ?
-    BROTHER = "brother"
+    ready = False
 
-
+    def __init__(self, app, device_id, vendor_id):
-# For Brother-QL Printers
+        super(Printer, self).__init__()
-@dataclass
-class PrinterInfo:
-    """
-    Brother-QL printer information
-    """
-    identifier: str
-    backend: str
-    protocol: str
-    vendor_id: str
-    product_id: str
-    serial_number: str
-    name: str = "Brother QL Printer"
-    model: str = "QL-570"
-    status: str = "unknown"
-    label_type: str = "unknown"
-    label_size: str = "unknown"
-    label_width: int = 0
-    label_height: int = 0
-
-    def __getitem__(self, item):
-        return getattr(self, item)
-
-    def __setitem__(self, key, value):
-        setattr(self, key, value)
-
-
-class Printer(ABC):
-    """
-    If it outputs printed paper and speaks like a printer, then it must be a printer.
-    """
-
-    def __init__(self, app, vendor_id, device_id, printer_type: PrinterType):
-        """
-        We initialize a Printer via it's USB connexion, and generate a unique ID
-        """
-        self.id = uuid.uuid4()
         self.app = app
-        self.vendor_id = vendor_id
-        self.device_id = device_id
         self.ready = False
-        self.printer_type = printer_type
-        self._lock = threading.Lock()
-
-    @abstractmethod
-    def _has_paper(self) -> bool:
-        """Check if the printer has papier"""
-
-    @abstractmethod
-    def _state(self) -> bool:
-        """Reports the state of the Printer"""
-
-    @abstractmethod
-    def print_task(self, task_type, data) -> None:
-        """Takes a PrintTask and executes it"""
-
-
-class EscPosPrinter(Printer):
-    """
-    Create a new ESC/POS based printer.
-    """
-
-    def __init__(self, app, vendor_id, device_id):
-        """
-        Create a connexion to a ESC/POS Printer via USB,
-        Making sure the printer is alive,
-        Making sure it has paper,
-        Define default print settings
-        """
-        super().__init__(app, vendor_id, device_id, printer_type=PrinterType.EPSON)
         self.printer = None
+        self.device_id = device_id
+        self.vendor_id = vendor_id
         self.usb_args = {}
-        self.usb_args["idVendor"] = self.vendor_id
+        self.usb_args["idVendor"] = self.device_id
-        self.usb_args["idProduct"] = self.device_id
+        self.usb_args["idProduct"] = self.vendor_id
 
-        try:
+    def check_paper(self) -> bool:
-            # This also calls open(), which we need to close()
+        """
-            # or else the device will appear as busy.
+        On printers that support it, we check that the printer has paper
-            p = escpos.printer.Usb(self.vendor_id, self.device_id, 0, profile="TM-P80")
+        """
-        except escpos.exceptions.DeviceNotFoundError as e:
+        self.app.logger.debug("Checking paper status...")
-            self.app.logger.error(
+        self.printer.open(self.usb_args)
-                "The USB device is not plugged in : %s",
+        status = self.printer.paper_status()
-                str(e),
+        match status:
-            )
+            case 0:
-        except Exception as e:
+                self.app.logger.error("Printer has no more paper, aborting...")
-            self.app.logger.error("Printer could not be connected : %s ", str(e))
+                self.printer.close()
+                raise RuntimeError("No more paper in the printer")
+            case 1:
+                self.app.logger.warning(
+                    "Printer needs paper to be changed very soon ! "
+                )
+                self.printer.close()
+            case 2:
+                self.app.logger.debug("Printer has paper, good to go")
+                self.printer.close()
 
-        try:
+    def init_printer(self):
-            if p.is_online():
+        """
-                self.app.logger.debug("Printer online !")
+        Check if the printer online ? Is the communication with the printer successfull ?
-        except Exception as e:
+        """
-            raise e
+
+        # TODO: This could happen directly when creating a new Printer class
+        if os.getenv("FLASK_DEBUG"):
+            waiting_elapsed = 15
+        else:
+            waiting_elapsed = 10
+
+        self.app.logger.debug("Waiting for printer to get online...")
+
+        while not self.ready:
+            try:
+                # This also calls open(), which we need to close()
+                # or else the device will appear as busy.
+                p = escpos.printer.Usb(
+                    self.device_id, self.vendor_id, 0, profile="TM-P80"
+                )
+            except Exception as e:
+                self.app.logger.error(
+                    "The USB device is not plugged in, trying again %s : %s",
+                    waiting_elapsed,
+                    str(e),
+                )
+                pass
+
+            try:
+                if p.is_online():
+                    self.ready = True
+                    self.app.logger.debug("Printer online !")
+            except Exception as e:
+                self.app.logger.error(
+                    "Error while getting the printer online %s : %s",
+                    waiting_elapsed,
+                    str(e),
+                )
+                pass
+
+            sleep(1)
+            waiting_elapsed -= 1
+            if waiting_elapsed < 1:
+                self.app.logger.error(
+                    "Printer took more than 30 seconds to get online, aborting..."
+                )
+                waiting_elapsed = 1  # Reset the waiting time for the next print.
+                return False
 
         # Setting up the printing options.
         p.set(
@@ -144,38 +130,15 @@ class EscPosPrinter(Printer):
         # Beware : if we print every time the printer becomes ready, it means
         # we are printing before and after every print !
         self.printer = p
-        self.printer.close()  # We close the connexion to the Printer
-
-        try:
-            self._has_paper()
-        except Exception as e:
-            raise e
-
         self.ready = True
+        self.printer.close()
 
-    def _has_paper(self):
+        self.check_paper()
-        """Check if the printer has paper left"""
+
-        self.app.logger.debug("Checking paper status...")
+        return True
-        self.printer.open(self.usb_args)
+
-        status = self.printer.paper_status()
+    def _print_sms(self, msg, signature="", bold=False):
-        match status:
-            case 0:
-                self.app.logger.error("Printer has no more paper, aborting...")
-                self.printer.close()
-                raise RuntimeError("No more paper in the printer")
-            case 1:
-                self.app.logger.warning(
-                    "Printer needs paper to be changed very soon ! "
-                )
-                self.printer.close()
-                return True
-            case 2:
-                self.app.logger.debug("Printer has paper, good to go")
-                self.printer.close()
-                return True
 
-    def _print_txt(self, msg, signature="", bold=False):
-        self.ready = False
         if not isinstance(msg, str):
             self.app.logger.error(
                 "It is not possible to print a " + str(type(msg)) + ", only strings."
@@ -191,7 +154,7 @@ class EscPosPrinter(Printer):
             self.app.logger.warning(
                 "Could not print message of this length: " + str(len(clean_msg))
             )
-            raise RuntimeError(
+            raise Exception(
                 "Could not print message of this length :"
                 + str(len(clean_msg))
                 + ", needs to be below 4096 caracters long."
@@ -201,7 +164,7 @@ class EscPosPrinter(Printer):
             self.app.logger.warning(
                 "Could not print signature of this length: " + str(len(clean_signature))
             )
-            raise RuntimeError(
+            raise Exception(
                 "Could not print signature of this length :"
                 + str(len(clean_signature))
                 + ", needs to be below 256 caracters long."
@@ -215,7 +178,6 @@ class EscPosPrinter(Printer):
             self.printer.textln(clean_msg)
             if clean_signature:
                 self.printer.textln(clean_signature)
-            self.printer.textln()
             self.printer.close()
         except Exception as e:
             self.app.logger.error("Unable to print because : " + str(e))
@@ -224,10 +186,9 @@ class EscPosPrinter(Printer):
             ) from e
 
         self.app.logger.info("Printed text")
-        self.ready = True
+        return True
 
     def _print_img(self, path, signature="", center=True, process=False):
-        self.ready = False
         clean_signature = str(signature)
 
         if len(signature) > 256:
@@ -247,39 +208,36 @@ class EscPosPrinter(Printer):
                 + str(path)
                 + " wasn't found. Please try again."
             )
-
+        else:
-        self.app.logger.debug("Printing file from " + str(path))
+            self.app.logger.debug("Printing file from " + str(path))
 
         if process:
             try:
                 self.app.logger.debug("Proccessing the image")
-                processed_path = _process_image(self, path)
+                path = _process_image(self, path)
             except RuntimeError as e:
                 self.app.logger.error(
                     "Error while processing the image, aborting print : %s", str(e)
                 )
                 raise e
         else:
-            processed_path = path
             self.app.logger.warning("Not proccessing the image")
 
         try:
             self.printer.open(self.usb_args)
-            self.printer.image(processed_path, center=center)
+            self.printer.image(path, center=center)
             self.printer.textln(signature)
             self.printer.close()
-            self.app.logger.debug("Printed an image : " + str(processed_path))
+            self.app.logger.debug("Printed an image : " + str(path))
         except Exception as e:
             self.app.logger.error(str(e))
             raise RuntimeError("Could not print the picture") from e
         finally:
             try:
                 os.remove(path)
-                os.remove(processed_path)
             except OSError as e:
                 raise e
 
-            self.app.logger.debug("Removed image : " + str(processed_path))
             self.app.logger.debug("Removed image : " + str(path))
 
             try:
@@ -291,25 +249,22 @@ class EscPosPrinter(Printer):
                 raise RuntimeError("Could not close the printer connexion. ") from e
 
         self.app.logger.info("Printed a picture")
-        self.ready = True
+        return True
 
     def _qr(self, content):
-        self.ready = False
         try:
             self.printer.open(self.usb_args)
             self.printer.qr(content, center=True)
-            self.printer.textln(content)
             self.printer.close()
-        except RuntimeError as e:
+        except Exception as e:
             self.printer.close()
             self.app.logger.error(str(e))
-            raise e
+            return False
 
         self.app.logger.info("Printed a QR")
-        self.ready = True
+        return True
 
     def _cut(self):
-        self.ready = False
         try:
             self.printer.open(self.usb_args)
             self.printer.cut()
@@ -320,236 +275,34 @@ class EscPosPrinter(Printer):
             raise e
 
         self.app.logger.info("Did a cut")
-        self.ready = True
+        return True
-
-    def _state(self) -> bool:
-        has_paper = self._has_paper()
-        is_ready = self.ready
-
-        self.app.logger.debug("Has paper : %s " , has_paper )
-        self.app.logger.debug("Ready : %s " , is_ready )
-
-        return is_ready and has_paper # and is_online
 
     def print_task(self, task_type, data):
         """Execute actual print based on task type"""
-
+        match (task_type.value):
-
+            case "text":
-        with self._lock:
+                self._print_sms(data["txt"], signature=data["sign"])
-            self.app.logger.debug("Acquired lock to start print")
+            case "image":
-
+                self._print_img(
-            i_m_ready = self._state()
+                    data["img"], signature=data["sign"], process=data["process"]
-            while not i_m_ready:
-                self.app.logger.debug("Waiting for the printer to become ready, current state %s ", str(i_m_ready))
-                i_m_ready = self._state()
-                time.sleep(0.3)
-
-            self.app.logger.debug("Checked state to start printing : %s", self._state())
-            self.ready = False
-            try:
-                self.app.logger.debug("Checking task type")
-                match (task_type.value):
-                    case "text":
-
-                        self._print_txt(data["txt"], signature=data["sign"])
-                        self.ready = True
-                    case "image":
-                        self._print_img(
-                            data["img"], signature=data["sign"], process=data["process"]
-                        )
-                        self.ready = True
-                    case "cut":
-                        self._cut()
-                        self.ready = True
-                    case "qr":
-                        self._qr(data["txt"])
-                        self.ready = True
-                    case _:
-                        raise RuntimeError("This task type is not supported")
-            except Exception as e:
-                self.app.logger.debug("Exception occured while printing %s", str(e))
-                self.ready = True
-                raise RuntimeError from e
-
-
-class BrotherPrinter(Printer):
-    """
-    Manages connexion and capabilities of a BrotherQL Printer
-    """
-
-    def __init__(self, app, vendor_id, device_id):
-        super().__init__(
-            app, vendor_id="", device_id="", printer_type=PrinterType.BROTHER
-        )
-        self.printer = None
-        self.usb_args = {}
-        self.usb_args["idVendor"] = self.device_id
-        self.usb_args["idProduct"] = self.vendor_id
-        self.model_manager = ModelsManager()
-
-        # Code taken from https://github.com/5shekel/printit/blob/master/printer_utils.py
-
-        backend = backend_factory("pyusb")
-        available_devices = backend["list_available_devices"]()
-
-        for printer in available_devices:
-            self.app.logger.debug(f"Found device: {printer}")
-            identifier = printer["identifier"]
-            parts = identifier.split("/")
-
-            if len(parts) < 4:
-                self.app.logger.warning(
-                    f"Skipping device with invalid identifier format: {identifier}"
                 )
-                continue
+            case "cut":
-
+                self._cut()
-            protocol = parts[0]
+            case _:
-            # device_info = parts[2]
+                raise RuntimeError("This task type is not supported")
-            serial_number = parts[3]
-
-        try:
-            product_id_int = int(self.device_id, 16)
-            for m in self.model_manager.iter_elements():
-                if m.product_id == product_id_int:
-                    model = m.identifier
-                    break
-            self.app.logger.debug(f"Matched printer model: {model}")
-        except ValueError:
-            self.app.logger.warning(f"Invalid product ID format: {m.product_id}")
-
-        self.printer_info = PrinterInfo(
-            identifier=identifier,
-            backend="pyusb",
-            model=model,
-            protocol=protocol,
-            vendor_id=vendor_id,
-            product_id=self.device_id,
-            serial_number=serial_number,
-        )
-
-        self.ready = True
-
-    def _has_paper(self):
-        raise NotImplementedError("This printer model does not support this.")
-
-    def _state(self):
-        return self.ready
-
-    def _print_img(self, data):
-        """
-        Print a raster image via a Brother QL printer
-        """
-        self.ready = False
-        label_type = "102"
-        rotate = 0
-        dither = False
-        try:
-            # Prepare the image for printing
-            qlr = BrotherQLRaster(self.printer_info["model"])
-
-            instructions = convert(
-                qlr=qlr,
-                images=[data["img"]],
-                label=label_type,
-                rotate=rotate,
-                threshold=70,
-                dither=dither,
-                compress=True,
-                red=False,
-                dpi_600=False,
-                hq=False,
-                cut=True,
-            )
-
-            # Debug logging
-            if os.getenv("FLASK_DEBUG"):
-                self.app.logger.debug(f"""
-                Print parameters:
-                - Label type: {label_type}
-                - Rotate: {rotate}
-                - Dither: {dither}
-                - Model: {self.printer_info['model']}
-                - Backend: {self.printer_info['backend']}
-                - Identifier: {self.printer_info['identifier']}
-                """)
-
-            # Try to print using Python API
-            # send() =  status = {
-            #     'instructions_sent': True, # The instructions were sent to the printer.
-            #     'outcome': 'unknown', # String description of the outcome of the sending operation like: 'unknown', 'sent', 'printed', 'error'
-            #     'printer_state': None, # If the selected backend supports reading back the printer state, this key will contain it.
-            #     'did_print': False, # If True, a print was produced. It defaults to False if the outcome is uncertain (due to a backend without read-back capability).
-            #     'ready_for_next_job': False, # If True, the printer is ready to receive the next instructions. It defaults to False if the state is unknown.
-            # }
-            status = send(
-                instructions=instructions,
-                printer_identifier=self.printer_info["identifier"],
-                backend_identifier="pyusb",
-            )
-
-            if (
-                not status["did_print"]
-                or status["outcome"] == "error"
-                or status["outcome"] == "unknown"
-            ):
-                raise RuntimeError("Failed to print using Python API")
-
-            if status["printer_state"]:
-                self.ready = bool(status["printer_state"])
-            else:
-                self.ready = True
-
-        except usb.core.USBError as e:
-            # Treat timeout errors as successful since they often occur after print completion
-            if e.errno == 110:  # Operation timed out
-                self.app.logger.debug(
-                    "USB timeout occurred - this is normal and the print likely completed"
-                )
-                self.app.logger.debug("Print completed (timeout is normal)")
-                self.ready = True
-
-            error_msg = f"USBError encountered: {e}"
-            self.app.logger.debug(error_msg)
-            raise RuntimeError from e
-
-        except Exception as e:
-            error_msg = f"Unexpected error during printing: {str(e)}"
-            self.app.logger.debug(error_msg)
-            raise RuntimeError from e
-
-    def print_task(self, task_type, data):
-        """Execute actual print based on task type"""
-        with self._lock:
-            if self._state:
-                self._state = False
-                match (task_type.value):
-                    case "image":
-                        self._print_img(data["img"])
-                        self._state = True
-                    case "cut":
-                        # The cut happens by default on Brother QL printers.
-                        self._state = True
-                    case _:
-                        raise RuntimeError("This task type is not supported")
-            else:
-                raise RuntimeError("The printer is not ready to print yet !")
-
-        # These values are by default for now
-
-        # raise NotImplementedError("This printer type is not implemented yet")
 
 
 def _process_image(self, path):
     brightness_factor = 1.5  # Used only if image is too dark
     brightness_threshold = 100  # Brightness threshold (0–255)
-    contrast_factor = 2  # Less than 1.0 = lower contrast
+    contrast_factor = 0.6  # Less than 1.0 = lower contrast
     max_width = 575
     max_height = 1000
 
     with Image.open(path) as original_img:
         # Convert to RGB if needed (JPEG doesn't support alpha)
         if original_img.mode in ("RGBA", "P"):
-            self.app.logger.debug("Converting the image from RGBA to RGBA")
+            self.app.logger.debug("Converting the image to RGB from RGBA")
             original_img = original_img.convert("RGB")
 
         # Resize while maintaining aspect ratio
@@ -557,8 +310,7 @@ def _process_image(self, path):
         self.app.logger.debug("Resized the image")
 
         # # Convert to grayscale for dithering
-        # dithered_img = original_img.convert("L").convert("1")
+        # dithered_img = original_img.convert("L").convert("1")  # Dithering using default method (Floyd–Steinberg)
-        # Dithering using default method (Floyd–Steinberg)
         # self.app.logger.debug("Dithered the image")
 
         # Compute brightness of original image (grayscale average)
@@ -579,19 +331,107 @@ def _process_image(self, path):
             self.app.logger.debug(
                 f"Image too dark, increasing brightness by a factor of {brightness_factor:.2f}"
             )
-            enhancer = ImageEnhance.Brightness(grayscale)
+            enhancer = ImageEnhance.Brightness(original_img)
-            grayscale = enhancer.enhance(brightness_factor)
+            original_img = enhancer.enhance(brightness_factor)
 
-        # Computer current contrast of grayscale image
+        # # Reduce contrast
-        contrast = np.clip(np.std(np.array(grayscale)), 0, 255)
+        # contrast_enhancer = ImageEnhance.Contrast(original_img)
-        self.app.logger.debug("Standard deviation of the contrast : %s", contrast)
+        # original_img = contrast_enhancer.enhance(contrast_factor)
-        # # Enhance contrast
-        contrast_enhancer = ImageEnhance.Contrast(grayscale)
-        original_img = contrast_enhancer.enhance(contrast_factor)
 
         # Convert to JPEG and save
         jpeg_path = os.path.splitext(path)[0] + "_processed.jpg"
-        grayscale.save(jpeg_path, format="JPEG", quality=95, optimize=True)
+        original_img.save(jpeg_path, format="JPEG", quality=95, optimize=True)
         self.app.logger.debug("Processed and saved image.")
 
     return jpeg_path
+
+
+def discover_printers():
+    """
+    We try to find all the connected printers ( 0 or n ) to this system.
+
+    For every type of supported printer, we try to autodiscover them.
+
+    http://www.linux-usb.org/usb.ids A list of USB vendor IDs
+
+    04b8  Seiko Epson Corp.
+    04f9  Brother Industries, Ltd
+    """
+
+
+def find_and_parse_borther_ql_printer():
+
+    ## We might be able to no use this because there is a `discover` command in https://github.com/pklaus/brother_ql#usage
+
+    ## Code stolen from https://framagit.org/stickoeur/diagnostickoeur/-/blob/no-masters/printit.py?ref_type=heads
+
+    """Find and parse Brother QL printer information."""
+
+    model_manager = ModelsManager()
+
+    # Debug print to show we're searching
+    # print("Searching for Brother QL printer...")
+
+    for backend_name in ["pyusb", "linux_kernel"]:
+        try:
+            # print(f"Trying backend: {backend_name}")
+            backend = backend_factory(backend_name)
+            available_devices = backend["list_available_devices"]()
+            # print(f"Found {len(available_devices)} devices with {backend_name} backend")
+
+            for printer in available_devices:
+                # print(f"Found device: {printer}")
+                identifier = printer["identifier"]
+                parts = identifier.split("/")
+
+                if len(parts) < 4:
+                    # print(f"Skipping device with invalid identifier format: {identifier}")
+                    continue
+
+                protocol = parts[0]
+                device_info = parts[2]
+                serial_number = parts[3]
+
+                try:
+                    vendor_id, product_id = device_info.split(":")
+                except ValueError:
+                    # print(f"Invalid device info format: {device_info}")
+                    continue
+
+                # Default model
+                model = "QL-570"
+
+                # Try to match product ID to determine actual model
+                try:
+                    product_id_int = int(product_id, 16)
+                    for m in model_manager.iter_elements():
+                        if m.product_id == product_id_int:
+                            model = m.identifier
+                            break
+                    # print(f"Matched printer model: {model}")
+                except ValueError:
+                    # print(f"Invalid product ID format: {product_id}")
+                    continue
+
+                printer_info = {
+                    "identifier": identifier,
+                    "backend": backend_name,
+                    "model": model,
+                    "protocol": protocol,
+                    "vendor_id": vendor_id,
+                    "product_id": product_id,
+                    "serial_number": serial_number,
+                }
+                # print(f"Found printer: {printer_info}")
+                return printer_info
+
+        except Exception as e:
+            # print(f"Error with backend {backend_name}: {str(e)}")
+            continue
+
+    print("No Brother QL printer found")
+    return None
+
+
+def fint_and_parse_epson_printer():
+    pass

src/printers.py

@@ -1,160 +0,0 @@
-"""
-A collection of Printers.
-
-It has methods to discover printers, and provides an interface for
-the methods expected from printers.
-"""
-
-from collections.abc import Set
-import usb.core
-import usb.util
-from printer import Printer, EscPosPrinter, BrotherPrinter
-
-
-class Printers:
-    """
-    Finds and creates a set of Printer that can be used by the Workers to print.
-    """
-
-    def __init__(self, app):
-        """
-        Discover printers connected to the computer and return a Collection of Printer()
-        """
-        self.app = app
-        self.printers = self._discover_printers()
-
-    def _discover_printers(self) -> Set[Printer]:
-        """
-        Gets connected USB printer devices using the pyusb library.
-
-        We analyse the USB devices, get the ones that match
-        the printer class ( 7 ) and for Brother and EPSON printers,
-        try to create a Printer object that can be used by the Worker class
-        to execute prints.
-
-        Returns a set of Printer
-        """
-
-        self.app.logger.debug("Discovering USB Devices connected to this system")
-
-        printers = set()
-
-        # Find all connected USB devices
-        devices = usb.core.find(find_all=True, custom_match=_FindClass(7))
-        if not devices:
-            self.app.logger.warning(
-                "No USB devices of class 7 ( printers ) found or pyusb could not access the bus."
-            )
-            raise RuntimeError(
-                "No USB devices of class 7 ( printers ) found or pyusb could not access the bus."
-            )
-
-        for dev in devices:
-            # Attempt to get the manufacturer and product strings
-            try:
-                manufacturer = usb.util.get_string(dev, dev.iManufacturer)
-            except Exception:
-                manufacturer = "Unknown"
-
-            try:
-                product = usb.util.get_string(dev, dev.iProduct)
-            except Exception:
-                product = "Unknown"
-            self.app.logger.debug(
-                "Looking at %s %s (%s:%s)",
-                manufacturer,
-                product,
-                hex(dev.idVendor),
-                hex(dev.idProduct),
-            )
-
-            if manufacturer == "EPSON":
-                try:
-                    # We create a new EscPosPrinter()
-                    self.app.logger.debug("Trying to creat a new EPSON printer")
-                    prid = dev.idProduct
-                    vendir = dev.idVendor
-                    escpos_printer = EscPosPrinter(
-                        self.app, vendor_id=vendir, device_id=prid
-                    )
-                except Exception as e:
-                    raise e
-
-                # If the object creation is successfull, we add it to the list of Printers
-                printers.add(escpos_printer)
-                self.app.logger.debug("Found a %s printer", manufacturer)
-
-                # We already found the type of printer,
-                # we don't need an extra comparaison.
-                continue
-
-            # or a Brother Printer
-            if manufacturer == "Brother":
-                try:
-                    # We create a new BrotherPrinter()
-                    self.app.logger.debug("Trying to creat a new BROTHER printer")
-                    prid = dev.idProduct
-                    vendir = dev.idVendor
-                    brother_printer = BrotherPrinter(
-                        self.app, vendor_id=vendir, device_id=prid
-                    )
-                except Exception as e:
-                    self.app.logger.error(
-                        "Could not create a %s printer class with %s:%s" , product,
-                        dev.idVendor,
-                        dev.idProduct,
-                    )
-                    raise e
-
-                # If the object creation is successfull, we add it to the list of Printers
-                printers.add(brother_printer)
-                self.app.logger.debug("Found a %s printer" , manufacturer)
-
-        self.app.logger.debug("Found %s printers" , len(printers))
-
-        if len(printers) < 1:
-            self.app.logger.warning("Not printers found ! Please plug in a Printer and restart the program.")
-            raise RuntimeError("No printers found")
-
-        return printers
-
-    def any(self) -> Printer:
-        """
-        Return a dict key: UUID, value: Printer, with any connected printer.
-        """
-        if len(self.printers) > 0:
-            for i in self.printers:
-                return i
-        else:
-            raise RuntimeError("No printers available")
-
-    # def get_printer(self, printer_type):
-    #     """
-    #     Return a specific printer
-
-    #     printer_type -- a printer type
-    #     """
-    #     return NotImplementedError()
-
-
-class _FindClass:
-    """
-    Use by usb.core to modify the way USB devices are found
-    Taken from pyUSB documentation on Github
-    """
-    def __init__(self, class_):
-        self._class = class_
-
-    def __call__(self, device):
-        # first, let's check the device
-        if device.bDeviceClass == self._class:
-            return True
-        # ok, transverse all devices to find an
-        # interface that matches our class
-        for cfg in device:
-            # find_descriptor: what's it?
-            intf = usb.util.find_descriptor(cfg, bInterfaceClass=self._class)
-            if intf is not None:
-                return True
-
-        return False

src/raspberry.py

@@ -1,21 +1,12 @@
-"""
-This class executes when we are on a raspberry Pi.
-
-It handles the press of a button via GPIO,
-activates a flash and prints out the picture
-that was taken via a USB Webcam.
-"""
-
 import io  # To check if we are on a Raspberry Pi
 import subprocess
 import os
 from time import sleep, gmtime, strftime
+from flask_socketio import SocketIO
 from gpiozero import Button, LED, DigitalOutputDevice
 from PIL import Image
-from task import TextTask, ImageTask, CutTask
 
-
+class Raspberry():
-class Raspberry:
     """
     This class will manage three things :
     - Connecting to a USB webcam
@@ -23,29 +14,32 @@ class Raspberry:
     - Activating a flash ( or light )
     - Flash an indicator light
 
-    # pylint: disable=too-many-instance-attributes
-    # dede
     """
 
     def __init__(
         self,
-        print_queue,
+        printer,
         app,
-        configuration_file
+        socketio,
+        button_gpio_port_number,
+        indicator_gpio_port_number,
+        flash_gpio_port_number,
+        is_flash_present,
     ):
-        self.print_queue = print_queue
+        self.printer = printer
+        self.socketio = socketio
         self.app = app
-        self.configuration_file = configuration_file
+
+        self.flash_gpio = flash_gpio_port_number
+        self.is_flash_present = is_flash_present
+        self.button_gpio = button_gpio_port_number
+        self.led_gpio = indicator_gpio_port_number
         self.image_path = self.app.config["UPLOAD_FOLDER"] + "/image.jpg"
 
-    def is_raspberry_pi(self):
+    def is_raspberry_pi(self, raise_on_errors=False):
-        """
-        Checking if we are on a Raspberry Pi by checking
-        information on the /proc/cpuinfo file
-        """
         # Check if we are running on a raspberry pi
         try:
-            with io.open("/proc/cpuinfo", "r", encoding="utf-8") as cpuinfo:
+            with io.open("/proc/cpuinfo", "r") as cpuinfo:
                 found = False
                 for line in cpuinfo:
                     if line.startswith("Hardware"):
@@ -65,10 +59,9 @@ class Raspberry:
                             return False
 
                 if not found:
-                    self.app.logger.warning(
+                    self.app.logger.error(
-                        "Couldn't get sufficient hardware information from /proc/cpuinfo"
+                        "Couldn't get sufficient hardware information from /proc/cpuinfo, Unable to determine if we are on a Raspberry Pi."
                     )
-                    self.app.logger.warning("Unable to determine if we are on a Raspberry Pi.")
                     return False
         except IOError:
             self.app.logger.error("Unable to open `/proc/cpuinfo`.")
@@ -77,38 +70,28 @@ class Raspberry:
         self.app.logger.debug("It seems we are on a Raspberry Pi")
 
         try:
-            self._initialise_gpio()
+            self.initialise_gpio()
         except Exception as e:
             self.app.logger.debug("Could not init GPIO : " + str(e))
             raise e
         return True
 
-    def _initialise_gpio(self):
+    def initialise_gpio(self):
-        """
-        Set GPIO ports from configuration and activate them
-        to show the user it's working.
-        """
         self.app.logger.debug("Initializing GPIO")
 
-        self.led = LED(self.configuration_file["rpi"]["indicator_gpio_port_number"])
+        self.led = LED(self.led_gpio)
         self.app.logger.debug("Activated indicator LED")
         self.indicator_countdown(iters=3)
-        self.button = Button(
+        self.button = Button(self.button_gpio, pull_up=True, bounce_time=0.1)
-            self.configuration_file["rpi"]["button_gpio_port_number"],
-            pull_up=True, bounce_time=0.1
-        )
         self.button.when_pressed = self.on_button_pressed
         self.app.logger.debug("Activated button")
 
         # The "flash" is a relay-controlled device ( light bulb for example )
-        self.flash = DigitalOutputDevice(self.configuration_file["rpi"]["flash_gpio_port_number"])
+        self.flash = DigitalOutputDevice(self.flash_gpio)
         self.flash_toggle()
         self.app.logger.debug("Activated flash")
 
     def indicator_countdown(self, iters=10, multi=10):
-        """
-        Activates the LED faster and faster to show a countdown
-        """
         for i in range(iters, 0, -1):
             self.led.on()
             sleep(i / multi)
@@ -116,10 +99,7 @@ class Raspberry:
             sleep(i / multi)
 
     def indicator_led(self, timing=0.2, l=5):
-        """
+        for i in range(l):
-        Turns on the indicator LED for a certain period of time
-        """
-        for _ in range(l):
             self.app.logger.debug("LED turned on")
             self.led.on()
             sleep(timing)
@@ -128,9 +108,6 @@ class Raspberry:
             sleep(timing)
 
     def flash_toggle(self):
-        """
-        Flashes the flash
-        """
         self.app.logger.debug("Flash turned on")
         self.flash.on()
         sleep(0.3)
@@ -138,9 +115,6 @@ class Raspberry:
         self.app.logger.debug("Flash turned off")
 
     def take_picture(self):
-        """
-        Takes a picture via the USB webcam
-        """
         # Validate if the image path is valid
         if not os.path.isdir(os.path.dirname(self.image_path)):
             self.app.logger.error(
@@ -166,7 +140,7 @@ class Raspberry:
                 f"Unable to take a picture. Error: {e.stderr.decode()}"
             )
             return False
-        except RuntimeError as e:
+        except Exception as e:
             # Catch any unexpected errors
             self.app.logger.error(f"Unexpected error while taking picture: {str(e)}")
             return False
@@ -186,9 +160,6 @@ class Raspberry:
         position="bottom_right",
         margin=10,
     ):
-        """
-        Takes an image and overlays it with a another picture.
-        """
         try:
             image = Image.open(image_path).convert("RGBA")
             logo = Image.open(logo_path).convert("RGBA")
@@ -215,9 +186,7 @@ class Raspberry:
                 y = image.height - logo.height - margin
             else:
                 raise ValueError(
-                    "Invalid position." +
+                    "Invalid position. Choose from 'bottom_right', 'top_left', 'top_right', or 'bottom_left'."
-                    "Choose from 'bottom_right', 'top_left', " +
-                    " 'top_right', or 'bottom_left'."
                 )
 
             # Composite the logo onto the image
@@ -228,16 +197,13 @@ class Raspberry:
                 output_path = image_path  # Overwrite the original image if no output path is given
             image.save(output_path)
 
-        except RuntimeError as e:
+        except Exception as e:
             self.app.logger.error(f"Error overlaying logo: {e}")
             return False
 
         return True
 
     def crop_to_square(self, image_path, output_path=None):
-        """
-        Crop an image so that it becomes a square
-        """
         try:
             image = Image.open(image_path)
             width, height = image.size
@@ -258,17 +224,13 @@ class Raspberry:
 
             image.save(output_path)
 
-        except RuntimeError as e:
+        except Exception as e:
             self.app.logger.error(f"Error cropping image to square: {e}")
             return False
 
         return True
 
     def on_button_pressed(self):
-        """
-        When a button press is detected, a picture is taken from the webcam
-        and added to the print queue.
-        """
         self.app.logger.debug("Button has been pressed")
         self.led.on()
         self.app.logger.debug("Counting down")
@@ -279,7 +241,7 @@ class Raspberry:
         try:
             self.flash.on()
             self.take_picture()
-        except RuntimeError as e:
+        except Exception as e:
             self.app.logger.error(
                 "Could not take a picture after the button press : " + str(e)
             )
@@ -288,13 +250,15 @@ class Raspberry:
         self.app.logger.debug("Printing picture")
         self.led.on()
         self.crop_to_square(self.image_path)
-        self.print_queue.enqueue(ImageTask(self.image_path, signature="", process=True))
+        self.printer.print_img("src/static/images/extase-club.png", process=True)
-        self.print_queue.enqueue(
+        self.printer.print_img(self.image_path, process=True)
-            TextTask(content="Imprimé par LittlePrynter", signature="")
+        self.printer.print_sms("")
-        )
+        self.printer.print_sms("With Love From Société.Vide", signature="", bold=True)
-        time = strftime("%Y-%m-%d %H:%M", gmtime())
+        self.printer.print_sms("Printed by LittlePrynter", signature="")
-        self.print_queue.enqueue(TextTask(content=time, signature=""))
+        self.printer.print_sms("n07070.xyz", signature="")
-        self.print_queue.enqueue(CutTask())
+        self.printer.print_sms(strftime("%Y-%m-%d %H:%M", gmtime()), signature="")
+        self.printer.qr("https://n07070.xyz/articles/littleprynter")
+        self.printer.cut()
         self.led.off()
-        self.app.logger.debug("Added a photomaton picture to the print queue")
+        self.app.logger.debug("Done printing picture")
         return True

src/task.py

@@ -14,11 +14,11 @@ to print at the same time.
 We can also delay and store printing tasks until a printer becomes
 available if none is online.
 """
-
 from abc import ABC, abstractmethod
 
 ## See https://docs.python.org/3/library/abc.html to learn more about this
 
+# from dataclasses import dataclass
 from enum import Enum
 import uuid
 
@@ -28,11 +28,9 @@ class TaskType(Enum):
     """
     The different tasks supported by the printers
     """
-
     TEXT = "text"
     IMAGE = "image"
     CUT = "cut"
-    QR = "qr"
 
 
 class PrintTask(ABC):
@@ -40,15 +38,18 @@ class PrintTask(ABC):
     A print task holds information about what we are looking to print.
     """
 
-    def __init__(self, task_type: TaskType):
+    def __init__(self, task_type):
         self.task_id = self._generate_id()
         self.task_type = task_type
         self.status = "pending"  # pending, processing, completed, failed
 
+        print("Created a new " + str(self.task_type) + " with ID " + self.task_id)
+
     @abstractmethod
     def get_print_data(self):
         """Return data formatted for printer"""
 
+
     def _generate_id(self):
         # Generate unique task ID
         return str(uuid.uuid4())
@@ -68,18 +69,6 @@ class TextTask(PrintTask):
         return {"txt": self.content, "sign": self.signature}
 
 
-class QRTask(TextTask):
-    """This task prints a QR-Code, the signature is ignore and is always the content itself"""
-
-    def __init__(self, content):
-        super().__init__(content, signature="")
-        self.content = content
-        self.signature = content
-
-    def get_print_data(self):
-        return {"txt": self.content, "sign": self.signature}
-
-
 class ImageTask(PrintTask):
     """
     This tasks represents a image content ( in the form of it's path ), and it's signature.

src/templates/index.html

@@ -6,8 +6,7 @@
       <h3 class="card-header">Print a short message</h3>
       <div class="card-body">
         <form class="form-group" action="/web/print/sms" method="post">
-          <textarea class="form-control" type="text" name="txt" placeholder="4096 chars or less " maxlength="4096"></textarea>
+          <input class="form-control" type="text" name="txt" placeholder="200 chars or less " maxlength="200" required><br>
-          <br>
           <input class="form-control" type="text" name="signature" placeholder="Signature or pseudo" maxlength="200"><br>
           <input class="btn btn-primary float-right" type="submit" value="Imprimer" name="imprimer">
         </form>

src/web.py

@@ -1,15 +1,12 @@
-"""
+from flask import flash
-Manage all of the inputs from a web source
-"""
-
-import os
 from werkzeug.utils import secure_filename
+import time
+import os
 from task import TextTask, ImageTask, CutTask
 
 
-class Web:
+class Web(object):
-    """Web is the class that gets all of the information from web calls
+    """Web is the class that gets all of the information from web calls ( API and Web page ) and provides checks before sending stuff to printing"""
-    ( API and Web page ) and provides checks before sending stuff to printing"""
 
     def __init__(self, app, print_queue):
         super(Web).__init__()
@@ -44,7 +41,7 @@ class Web:
             file_uploaded = self.upload_file(image)
         except Exception as e:
             self.app.logger.error(e)
-            raise RuntimeError("Could not upload file : " + str(e)) from e
+            raise RuntimeError("Could not upload file") from e
 
         if file_uploaded:
             self.app.logger.debug("File has been uploaded, printing...")
@@ -68,19 +65,16 @@ class Web:
 
         return True
 
-    # def login(self, username: str, password: str) -> bool:
+    def login(self, username: str, password: str) -> bool:
-    #     """Not implemented"""
+        """Not implemented"""
-    #     return
+        return
 
-    # def logout(self, username: str, password: str) -> bool:
+    def logout(self, username: str, password: str) -> bool:
-    #     """Not implemented"""
+        """Not implemented"""
-    #     return
+        return
 
     def allowed_file(self, filename) -> bool:
-        """
+        self.app.logger.debug("Is the filename allowed ?")
-        Check if the file extension is allowed
-        """
-        self.app.logger.debug("Checking if the file extension is allowed")
         return (
             "." in filename
             and filename.rsplit(".", 1)[1].lower()
@@ -88,11 +82,8 @@ class Web:
         )
 
     def upload_file(self, image) -> bool:
-        """
-        Save the file after executing checks on it
-        """
         self.app.logger.debug("Validating file")
-        if not image is None or not image == "":
+        if image:
             if self.allowed_file(image.filename):
                 filename = secure_filename(image.filename)
                 self.app.logger.debug("File valid")
@@ -100,23 +91,24 @@ class Web:
                     image.save(os.path.join(self.app.config["UPLOAD_FOLDER"], filename))
                 except OSError as e:
                     self.app.logger.error("Could not save file %s", e)
-                    raise RuntimeError("An OS error occured while uploading this file : " + str(e)) from e
+                    return False
 
                 self.app.logger.debug(
                     "File saved to "
                     + str(os.path.join(self.app.config["UPLOAD_FOLDER"], filename))
                 )
                 return True
-
+            else:
-        self.app.logger.error(
+                self.app.logger.error(
-            "Could not save file because the filename is forbidden"
+                    "Could not save file because the filename is forbidden"
-        )
+                )
-        raise RuntimeError("This file type is forbidden.")
+                return False
+        else:
+            self.app.logger.error(
+                "Could not save file, it seems to be null ? : " + str(filename)
+            )
+            return False
 
     def get_queue_state(self):
         """Return current queue state"""
         return self.print_queue.get_queue_state()
-
-    def get_queue_completed(self):
-        """Return completed queue elements"""
-        return self.print_queue.get_queue_completed()

src/worker.py

@@ -1,123 +1,84 @@
-"""
+# This is the main printing thread
-This is the main printing thread. A worker thread consums Tasks from
+# As explained in the task file, this is where we command
- a PrintQueue, while trying to find available printers.
+# printing to happen.
-"""
 
 import threading
 import time
-from printers import Printers
 
 
 class PrintWorker(threading.Thread):
-    """
+    def __init__(self, app, print_queue, printer, socketio=None):
-    A thread used to consume Tasks added to a Print Queue.
-
-    On initialisation, the worker will try to find Printers,
-    and on each print, choose an available Printer from a list of Printers.
-
-    If a print fails, it's not retried, but will be added to a list of completed
-    tasks.
-    """
-    def __init__(self, app, print_queue):
         super().__init__(daemon=True)
         self.app = app
         self.print_queue = print_queue
-        self.printer = None
+        self.printer = printer
-        self._lock = threading.Lock()
+        self.socketio = socketio  # Optional
         self.running = True
         self.state = "idle"  # idle, printing, dead, drinking-a-beer
-        self.app.logger.debug("Ho great, I'm alive... I'm ready to work another day...")
 
-        try:
+        self.app.logger.debug("Ho great, I'm alive... I'm ready to work another day...")
-            self.printers = Printers(self.app)
-            self.printers_obj = self.printers.printers
-            self.printers = iter(self.printers.printers)
-        except RuntimeError as e:
-            self.app.logger.warning("Could not get any Printers")
-            raise e
 
     def run(self):
         """Background thread that processes queue items"""
-        self.app.logger.debug("Worker %s started working.", threading.get_ident())
+        self.app.logger.info("Worker started working.")
-        self.app.logger.debug("Current threads : %s" , threading.active_count())
-        self.app.logger.debug("Threads actives : %s " , threading.enumerate())
-
         while True:
-
+            if not self.running or not self.printer.ready:
-            # If the printer is dead or asleep, it can't work.
-            if not self.running:
                 time.sleep(0.2)
                 continue
 
-            # If we have no available printer, we look at the list printers
+            try:
-            # we know about, and try to find one that is available.
+                task = self.print_queue.dequeue()
-            # When we find a printer, we acquire it
+            except Exception as e:
-            # When we are finished with a printer, we release it to the world.
+                self.app.logger.error("Could not get a new task ! %s ", str(e))
-            while not self.printer or not self.printer.ready:
+                raise RuntimeError(
-                time.sleep(1)
+                    "We could not get a new task because " + str(e)
+                ) from e
+
+            if task:
                 try:
-                    self.app.logger.debug("Changing printers")
+                    self.app.logger.info("Got a new task")
-                    self.printer = next(self.printers)
+                    self.app.logger.debug("Got task %s", task.task_id)
-                    self.app.logger.debug(
+                    self.state = "printing"
-                        "The worker got a %s printer and it's %s",
+                    task.status = "processing"
-                        self.printer.printer_type,
+                    self._emit_status(task.task_id, "processing")
-                        "Ready" if self.printer.ready else "Not ready",
-                    )
-                except Exception as e:
-                    self.app.logger.error("No printer detected" + str(e))
-                    self.printer = None
 
-            if self.state != "idle":
+                    print_data = task.get_print_data()
-                self.app.logger("We are not idle, waiting...")
-                time.sleep(1)
-                continue
-
-            self.state = "printing"
-
-            with self._lock:
-                try:
-                    task = self.print_queue.dequeue()
-                except Exception as e:
-                    self.app.logger.error("Could not get a new task ! %s ", str(e))
-                    self.state = "idle"
-                    raise RuntimeError(
-                        "We could not get a new task because " + str(e)
-                    ) from e
-
-                if task:
                     try:
-                        self.app.logger.info("Got a new task")
+                        self.printer.print_task(task.task_type, print_data)
-                        self.app.logger.debug("Got task %s", task.task_id)
-                        task.status = "processing"
-
-                        print_data = task.get_print_data()
-
-                        try:
-                            self.printer.print_task(task.task_type, print_data)
-                        except RuntimeError as e:
-                            self.state = "idle"
-                            self.app.logger.error("Could not print : %s", str(e))
-                            raise e
-
-                        task.status = "completed"
-                        self.print_queue.mark_completed(task.task_id, "completed")
-                        self.app.logger.debug(
-                            "Finished printing task %s " , task.task_id
-                        )
-                        self.state = "idle"
-
                     except RuntimeError as e:
-                        task.status = "failed"
+                        self.app.logger.error("Could not print : %s", str(e))
-                        self.state = "idle"
+                        raise e
-                        self.print_queue.mark_completed(task.task_id, "failed")
-                        self.app.logger.error(
-                            "Could not print task %s because %s " , task.task_id, str(e)
-                        )
 
-                else:
+                    task.status = "completed"
-                    # When they are no new tasks to handle, we put the thread to sleep.
+                    self.print_queue.mark_completed(task.task_id, "completed")
-                    self.state = "idle"
+                    self._emit_status(task.task_id, "completed")
-                    time.sleep(0.1)
+
+                except RuntimeError as e:
+                    task.status = "failed"
+                    self.print_queue.mark_completed(task.task_id, "failed")
+                    self._emit_status(task.task_id, "failed", error=str(e))
+                    print(f"Print task {task.task_id} failed: {e}")
+            else:
+                # When they are no new tasks to handle, we put the thread to sleep.
+                self.state = "idle"
+                time.sleep(0.1)
+
+    def _emit_status(self, task_id, status, error=None):
+        """Emit status update via Socket.IO if available"""
+        if not self.socketio:
+            return
+
+        room = f"task_{task_id}"
+        data = {
+            "task_id": task_id,
+            "status": status,
+            "position": None,  # Task no longer in queue
+        }
+
+        if error:
+            data["error"] = error
+
+        self.socketio.emit("task_status", data, room=room)
 
     def stop_worker(self):
         """
@@ -143,5 +104,4 @@ class PrintWorker(threading.Thread):
             "is_running": self.running,
             "queue_size": len(self.print_queue),
             "state": self.state,
-            "printers": len(self.printers_obj),
         }